BUG: MSIS density BCs not actually set, ok in main branch#67
Merged
abukowski21 merged 4 commits intodevelopfrom Sep 9, 2025
Merged
BUG: MSIS density BCs not actually set, ok in main branch#67abukowski21 merged 4 commits intodevelopfrom
abukowski21 merged 4 commits intodevelopfrom
Conversation
Contributor
Author
|
Run test fails because reference solution is most likely wrong. The boundary conditions on density were not being updated when MSIS was being used. I guess we need to update the solution. |
abukowski21
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSIS was called, but the variable that has the returned densities in it was not being used. This was fixed in the main branch, but not in develop. Now the oblate sphere works as expected.